Prevent italic or strikethrough emojis on Android #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tomekzaw
requested changes
Nov 7, 2024
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
tomekzaw
changed the title
tomekzaw
requested changes
Nov 13, 2024
android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java
Outdated
Show resolved
Hide resolved
|
I've tested this pr on very example app platform and E/App platforms and I could not find anything. Everything works well including preventing formatting on emojis. |
tomekzaw
requested changes
Dec 4, 2024
Comment on lines
3
to
5
| import org.json.JSONException; | ||
| import org.json.JSONObject; | ||
|
|
There was a problem hiding this comment.
Suggested change
| import org.json.JSONException; | |
| import org.json.JSONObject; |
There was a problem hiding this comment.
Just FYI, I also needed class MarkdownRange so I added it in #559. I hope you can reuse mine in this PR.
Open
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes adding italics and strikethrough style to the emojis on Android and web platforms
Related Issues
Expensify/App#14676
Manual Tests
_🥰 test 😇 test 🥹_# *~_🥰 test 😇 test 🥹_~*Linked PRs