Fix custom parsing on the web #585
Open
+46
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Dec 12, 2024
src/parseExpensiMark.ts
Outdated
| @@ -292,4 +292,4 @@ function parseExpensiMark(markdown: string): MarkdownRange[] { | |||
| return groupedRanges; | |||
| } | |||
|
|
|||
| export default parseExpensiMark; | |||
| export {parseExpensiMark, sortRanges}; | |||
There was a problem hiding this comment.
I don't think it's a good idea to export and use sortRanges from parseExpensiMark. This is a self-contained parser used as default which we plan to remove from the repo at some point so we shouldn't use any of its pieces in the library code. Instead, let's extract sortRanges to a separate file (maybe something like parserUtils.ts?) and import it here from there.
There was a problem hiding this comment.
Okay, I moved them to the rangeUtils since parserUtils.ts already exists on the web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds range sorting in web range to HTML parser in
parserUtils.ts. Web parsers requires sorted ranges to work properly, so we with fix we enforce the correct order of itemsfix.mov
Related Issues
#584
Manual Tests
@a #1Linked PRs