Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing images #3

Open
mdscheuerell opened this issue Feb 26, 2023 · 2 comments
Open

missing images #3

mdscheuerell opened this issue Feb 26, 2023 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@mdscheuerell
Copy link
Contributor

mdscheuerell commented Feb 26, 2023

Hey Megsie. Thanks for this. I was able to merge your PR after resolving a strange conflict in a file you wouldn't have touched 🤷🏼.

Re: this commit, I saved the images from your branch, committed them, and rebuilt the site. Everything seems to display just fine now when viewing your slides from the course website.

Also, two notes regarding ~/website/lectures/week_09/lec_25_intro_shiny_1.Rmd:

  1. I changed the course number from 497 to 549, which meant I had to re-knit your .Rmd.

  2. In the process of addressing (1), I had to install the {emo} package, but apparently it no longer installs on recent versions of R. Thus, I switched all of the emo::ji() calls over emoji::emoji().

@mdscheuerell mdscheuerell added bug Something isn't working enhancement New feature or request labels Feb 26, 2023
@MargaretSiple-NOAA
Copy link
Collaborator

Thanks Mark! Yes, sorry about the emo package. I had that same issue and found I had to install from Hadley's GitHub using devtools: devtools::install_github("hadley/emo")

Strangely, now that the images I added are working, the gifs and images I linked aren't hot-linking! That shows me for not making permanent images, but the URLs still work on their own so they should be working online. Hmmm.... I'll see if I can download them or something and re-upload. Sorry it's weird. I'll try to add much more leeway for Wednesday's lecture.

@MargaretSiple-NOAA
Copy link
Collaborator

Just to be clear, I have a working slide deck on my own machine, it's just that all my fun Spirited Away gifs don't render in the version that's on the website. It won't affect the content, just the aesthetic experience of some of the folks following along with that specific set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants