Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repository schema] Some simple types are not used. #195

Open
francescoloconte opened this issue Nov 20, 2023 · 2 comments · Fixed by #232
Open

[repository schema] Some simple types are not used. #195

francescoloconte opened this issue Nov 20, 2023 · 2 comments · Fixed by #232
Assignees
Labels
ERRATA Errors and omissions, inconsistencies

Comments

@francescoloconte
Copy link

The following types are defined in the schema but they do not seem to be used anywhere:

<xs:simpleType name="CategoryComponentType_t">
<xs:restriction base="xs:string">
<xs:enumeration value="Field"/>
<xs:enumeration value="Message"/>
</xs:restriction>
</xs:simpleType>

<xs:simpleType name="CompID_t">
<xs:restriction base="xs:positiveInteger">
<xs:minInclusive value="1000"/>
</xs:restriction>
</xs:simpleType>

<xs:simpleType name="GroupName_t">
<xs:restriction base="xs:string"/>
</xs:simpleType>

<xs:simpleType name="IncludeFile_t">
<xs:restriction base="xs:string">
<xs:enumeration value="components"/>
<xs:enumeration value="fields"/>
</xs:restriction>
</xs:simpleType>

@francescoloconte francescoloconte changed the title Some simple types are not used. [repository schema] Some simple types are not used. Nov 22, 2023
@francescoloconte
Copy link
Author

@kleihan , if these simple types are not used in the schema, is this a sufficient reason to remove them? Or can there be other reasons for which they should remain even if not used? There may be aspects of the standard am I not familiar with, that justify these staying in the schema. If you confirm they can be removed, I would submit a PR to remove them, and close this ticket.

@patricklucas
Copy link
Contributor

I can confirm that these are all unused, likely vestigial from Unified, and concur they can be removed.

patricklucas added a commit to patricklucas/fix-orchestra that referenced this issue Sep 10, 2024
Most of these types are vestigial, having been inherited from
repository2010.
@kleihan kleihan linked a pull request Sep 11, 2024 that will close this issue
@kleihan kleihan moved this to In progress in Orchestra v1.1 RC2 Sep 12, 2024
kleihan added a commit that referenced this issue Nov 4, 2024
[#195] Remove unused types from repository XSD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERRATA Errors and omissions, inconsistencies
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants