Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[md2orchestra] - "First group field not NumInGroup datatype" for TrdCapRptSideGrp #78

Open
RODonnell80 opened this issue Sep 13, 2023 · 0 comments

Comments

@RODonnell80
Copy link

There are at least two groups in the Orchestra representation of FIX Latest whose first field has a type defined as a CodeSet. For example, TrdCapRptSideGrp defines tag 552 as its first field, but the field is defined as having a type of NoSidesCodeSet. Using md2orchestra, I receive 2 errors when including this group in the source markdown:

First group field not NumInGroup datatype; id= 552 in group=TrdCapRptSideGrp
Unknown group; id= 2061 scenario=base

The resulting group definition in the XML has:

<fixr:group id="2094" name="TrdCapRptAckSideGrp">
            <fixr:fieldRef id="552"/>

Looking at other groups, I believe this should be:

<fixr:group id="2094" name="TrdCapRptAckSideGrp">
            <fixr:numInGroup id="552"/>

Following some debugging, it appears that the 'type' of the first field in the group is validated, but the validation does not take this special case into account. I.e. if the returned type is a CodeSet then the validation fails, even though the type associated with the CodeSet may be 'numInGroup' - this is not checked.

I believe this special case should be handled and the expected result should be:

  • No error or warning is printed
  • The resulting XML includes the first field as 'numInGroup' instead of 'fieldRef'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant