Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid URLs if okapi_url has a path component #67

Closed
kt-bvb opened this issue Sep 27, 2024 · 1 comment
Closed

Invalid URLs if okapi_url has a path component #67

kt-bvb opened this issue Sep 27, 2024 · 1 comment

Comments

@kt-bvb
Copy link

kt-bvb commented Sep 27, 2024

The changed URL handling introduced in #52 (where f-strings were replaced with urljoin to concatenate the okapi_url with the required API endpoint) results in invalid URLS if the okapi_url has a path component.

>>> urllib.parse.urljoin("https://www.example.org/path/to/okapi", "/authn/login-with-expiry")
'https://www.example.org/authn/login-with-expiry'

Since the path component from the okapi_url is ommited from the new (incorrect) URLs, login and the other methods fail.

@bltravis
Copy link
Contributor

Fixed by #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants