You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@banerjek My concern would be that this could result in value collisions. My inclination would be to log them as failed in the data issues log and indicate "invalid characters in po number".
That would work -- anything that makes it clear why orders fail is good.
So far, all the situations where this has been an issue were spaces and punctuation (i.e.more there for cosmetic reasons than part of PO -- including variable syntax for polines attached to the same PO). I should probably look at a lot more data to figure out the collision risk
@ealexch Just seeing this, and had a look at your branch. As mentioned above, I'm not entirely sure that the basic sanitization approach is appropriate here without some additional overhaul to flag potential duplicates and populate a data issues log.
Any character that doesn't match [A-Zaz0-9] should be stripped from PO Numbers -- otherwise won't load
The text was updated successfully, but these errors were encountered: