Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative timing unit test #397

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Negative timing unit test #397

wants to merge 3 commits into from

Conversation

rusefillc
Copy link
Contributor

No description provided.

@rusefillc rusefillc changed the title Negative timing Negative timing unit test Mar 20, 2024
@rusefillc rusefillc mentioned this pull request Mar 20, 2024
Open
mck1117
mck1117 reviewed Mar 20, 2024
View reviewed changes
unit_tests/tests/ignition_injection/test_ignition_scheduling.cpp
eth.assertRpm(0);
ASSERT_EQ(347, getAdvance(rpm, load));

// todo: ooops! negative advance not displayed right for 2 stroke engines!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please file an issue for new todos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and link the issue in code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mck1117 mck1117 mck1117 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rusefillc @mck1117