Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pallets Refactoring #269

Closed
wants to merge 15 commits into from
Closed

Pallets Refactoring #269

wants to merge 15 commits into from

Conversation

ndkazu
Copy link
Contributor

@ndkazu ndkazu commented Apr 18, 2023

No description provided.

@ndkazu ndkazu self-assigned this Apr 18, 2023
@ndkazu
Copy link
Contributor Author

ndkazu commented Apr 25, 2023

The new Roles_Pallet is now operational. next step before adding any other pallet:

  • Update the chain_spec file with all the different genesis (use main_branch as model)
  • Write the new tests
  • Write proper pallet benchmarking
  • Update the documentation

Concerning the new fixes & functionalities:

  • No restriction on the number of roles one can have
  • Servicer, Seller, & Notary roles requests need to go through a council vote for approval
  • Corrected clippy warnings
  • Sudo remains but is not used for roles attribution anymore. maybe we can use it to define the prime member in the Council pallet.

Additional remarks

  • Due to the polkadot library upgrade, several functions in the original pallet required syntaxical corrections, this will also be the case for other pallets, without doubt.
  • Replaced DispatchResults by DispatchResultsWithPostInfo whenever possible, as it is also extensively used in the substrate frame pallets.

@ndkazu ndkazu closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTORING] Upgrade to polkadot-v0.9.40 and rewrite-optimise pallet_Roles
1 participant