Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Python 3.7 compatibility and make sure it is back-portable to 2.7 #113

Open
e-lo opened this issue Jan 19, 2018 · 6 comments
Open

Check Python 3.7 compatibility and make sure it is back-portable to 2.7 #113

e-lo opened this issue Jan 19, 2018 · 6 comments
Assignees
@e-lo @lmz

Comments

@e-lo
Copy link
Member

e-lo commented Jan 19, 2018

No description provided.

@e-lo e-lo self-assigned this Jan 19, 2018
@e-lo
Copy link
Member Author

e-lo commented Jan 19, 2018

Now that Partridge is working.

@e-lo e-lo changed the title Check Python 3.5 compatibility and make sure it is back-portable to 2.7 Check Python 3.6.4 compatibility and make sure it is back-portable to 2.7 Jan 19, 2018
@e-lo
Copy link
Member Author

e-lo commented Jan 22, 2018

Will use steps described in https://docs.python.org/3/howto/pyporting.html
Note that this will add a dependency of the future package for python 2, but this seems to be the standard way to accomplish backward-compatible code.

@e-lo e-lo changed the title Check Python 3.6.4 compatibility and make sure it is back-portable to 2.7 Check Python 3.7 compatibility and make sure it is back-portable to 2.7 Aug 28, 2018
@e-lo
Copy link
Member Author

e-lo commented Aug 28, 2018

Still working through full testing, but after working thru a lot of stuff related to the c++ extension, I wanted to report this awesome results:

33% improvement in computation time was the only difference in a trace log file between py27 and py37 (w/ all other numbers same!) .

What whaaat! 👍

image

@e-lo
Copy link
Member Author

e-lo commented Aug 28, 2018

image

@e-lo
Copy link
Member Author

e-lo commented Aug 28, 2018

PR #177 is open and ready for SOMEbody to review, please.
@lmz ?

@e-lo e-lo assigned lmz Aug 28, 2018
@pedrocamargo
Copy link

With end of life of Python 2, shouldn't update the issue to compatibility with Python 3.6 trough 3.8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-lo e-lo

@lmz lmz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@e-lo @lmz @pedrocamargo