Changes to initial BufferRecyclerProvider PR #1085
Conversation
|
@cowtowncoder Thanks a lot. I will rebase #1064 against this commit and the former one and rework it accordingly. Please don't change anything in this area in the meanwhile, or at least warn me if you have to do so. |
| public interface BufferRecyclerPool | ||
| extends java.io.Serializable | ||
| { | ||
| public BufferRecycler acquireBufferRecycler(TokenStreamFactory forFactory); |
There was a problem hiding this comment.
@cowtowncoder I don't understand why this method takes a TokenStreamFactory as argument, can you please clarify?
There was a problem hiding this comment.
It allows inspecting configuration of the factory that creates parser/generator that needs recycler: mostly JsonFactory.Feature settings.
TokenStreamFactory is that abstract super-type of JsonFactory; could pass latter if that proves necessary.
Thanks, will try to avoid/limit changes in relevant areas. |
Addressing issues uncovered in the first PR to add pluggable BufferRecycler pooling.