Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Rework Rain scale bar and colors in the Maps tab #123

Open
adem4ik opened this issue Jul 9, 2022 · 7 comments
Open

[Suggestion] Rework Rain scale bar and colors in the Maps tab #123

adem4ik opened this issue Jul 9, 2022 · 7 comments
Assignees
Labels
enhancement visuals Visual artifacts.

Comments

@adem4ik
Copy link
Contributor

adem4ik commented Jul 9, 2022

Version: 1.23.0

  • Open Maps
  • Switch to Rain

Result: Rain is barely visible on the map, especially 0-6 mm. The problem comes from the gray colors on the gray/white background.

Proposed result: Use similar scale bar and colors as on https://openweathermap.org/weathermap?basemap=map&cities=false&layer=radar&lat=30&lon=-20&zoom=5

Current scale bar:
0.1 2 6 8 10 14 16 20 26 32 42 48 52 70+
Proposed scale bar:
0.1 0.5 1 2 4 6 8 10 12 14 16 24 32 60+

image

@FelixdelasPozas FelixdelasPozas self-assigned this Jul 9, 2022
@FelixdelasPozas FelixdelasPozas added enhancement visuals Visual artifacts. labels Jul 9, 2022
@FelixdelasPozas
Copy link
Owner

Hi @adem4ik.

Yes, that will be much more visible for the rain map. I'll change it for the next release. I was also thinking on modifying also the temperature map scale because here in Spain we're going to be 40+ ºC next week and the maximum in the map is 36. So all the map will be in red... I'm thinking in making the scale bars dynamic depending on the current weather conditions for better "reading" the maps. I'll tinker with it for a bit to see if it works.

Regards,
Félix.

@FelixdelasPozas
Copy link
Owner

Hello @adem4ik .

I've been playing a little bit with this and it's perfectly possible to do it, but only in the "advanced weather maps" of OpenWeatherMap. Those "Maps 2.0", as they call it, allows the developer to specify a range for map values and associate a color to each. It looks good indeed but it requires the developer subscription to OpenWeatherMaps (160€ a month), and that's something I can't afford right now for a free project. For now I'll use the free maps.

I'll leave the issue open so it remains visible, as this seems to be a frequently asked thing.

Regards,
Félix.

@alystair
Copy link

You could reach out to OpenWeatherMaps to see if they have any discounting/benefits for open source projects.

Alternatively potential costs could be deferred to users that specifically want the advanced functionality (using their own API keys or something) - although that seems like unnecessary feature creep :)

@FelixdelasPozas
Copy link
Owner

@alystair Yes, I suppose the application could try first to use the 2.0 maps and if it gets a "unauthorized" message from the server go back to use the old 1.0 maps.
I'm going to change the way the application works with "data providers" to add different weather info sites. I'll try to add it in then, or at least test it.

Regards,
Félix.

@JohnLGalt
Copy link

Just out of curiosity, while I understand the need to maybe adjust the scale a bit for the unusually high temps the world saw this year, does the Map 1.0 not already include color gradients and scales? Was your reason for changing the colors from default for a specific reason? Being in the USA, I only know of the different sites and apps I've used for weather here, but it seems that, at least here, scaling for precipitation always starts from the lightest of greens and progresses through green, then yellow, then orange, then red for the hardest of rain(and using hues based on blue for frozen precipitation).

I've always wondered why TW had set colors and not gradients, and used different colors than what I normally see everywhere else.

@FelixdelasPozas
Copy link
Owner

The reason was that the lightgray colors where barely visible in the precipitation and cloud maps, so a gradient like the one proposed by @adem4ik (using greens instead of gray for lower values of rain) is much more visible.
But in 1.0 maps you can ask for the rain map layer and the server will give you the map in a fixed gradient/colors then the application superimposes the rain layer to the "streetmap" layer (so OPW only gives you "the clouds" painted with the color it has, fixed).
To modify the gradient as @adem4ik suggested is only available in the 2.0 maps API when you can specify temperature ranges and colors in a parameter called "palette".
You can see the difference in parameters between 1.0 and 2.0 maps. The legend colors (what 2.0 calls palette) are fixed for 1.0 maps, so TW uses those colors.

@JohnLGalt
Copy link

Makes sense. Thanks for the response and explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement visuals Visual artifacts.
Projects
None yet
Development

No branches or pull requests

4 participants