Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuel.ignition.org to fuel.gazebosim.org #282

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

woensug-choi
Copy link
Collaborator

@woensug-choi woensug-choi commented Dec 1, 2023

As Ignition is now Gazebo (the name we all love). The models loading from Fuel Ignition (still old name) url is changed.
The models with loading from the Fuel Ignition, the cloud model library, need url changed.

This should fix #27 and #274

I will add some text in dave.doc for loading time (in my system, it took almost 5 minutes to download all models)

@mabelzhang
Copy link
Contributor

Added to WG kanban https://github.com/orgs/ros-maritime/projects/1

@woensug-choi
Copy link
Collaborator Author

#274

If the issuer of abbove issue doesn't respond, and nobody at the community could review. I would just merge it. It's a no harm change. I will wait for two weeks max :)

@mabelzhang
Copy link
Contributor

mabelzhang commented Jan 23, 2024

Hmm, I see that these are the new models we added in 2021. We have a copy of these on Fuel, those might need to be re-uploaded as well... If the URIs are actually pulling from Fuel and not the ones in this local repo, fixing the files in this repo wouldn't fix the error. But I see in the URI that the models on Fuel are all owned by different people... I don't think I can replace them. They would all have to be re-uploaded to a different account.

I haven't test it. Does this PR get rid of the errors for you?

If this PR doesn't fix the error, then maybe we should just refer to the local copies of the models and not use the ones on Fuel... until they can be re-uploaded. Ughhhh. But that's undoing all the uploading we did. And porting to new Gazebo actually works better with models on Fuel.

Sigh, the Ignition rename really sucks. We just had the same kind of error cropped up in the splash screen worlds in Harmonic today.

@woensug-choi
Copy link
Collaborator Author

Oh wow.. I haven't tested everything but the ones I've tested worked. This changes were first brought up after issues that the world was not launching. Modifying the URL as in this PR fixed it.

@woensug-choi
Copy link
Collaborator Author

woensug-choi commented Jan 30, 2024

@mabelzhang I shall be done with your review soon.. sorry. What do you think of publishing a new Release after this PR as it fixes the launch of world with new URL.

Added Uncommenting commit for joystick. This should be good to go.

@mabelzhang
Copy link
Contributor

Oh I meant in the diff for examples/dave_demo_launch/launch/dave_integrated_demo.launch, there's still a lot of other commented tags. Do they all need to be commented? The joystick was just one of many.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenCV compilation error
2 participants