Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'use strict'; #47

Open
Roboe opened this issue Jul 26, 2015 · 0 comments
Open

'use strict'; #47

Roboe opened this issue Jul 26, 2015 · 0 comments
Labels
CORE enhancement
Milestone
MBP✂ (Min Basic P...

Comments

@Roboe
Copy link
Member

Roboe commented Jul 26, 2015

We should 'use strict'; in all our .js files.
When I reformatted that files to comply with our code style, I tried to make them strict, but project object was not found because it is declared inside a closure and strict forced it to be local.

One posible solution is manage to put project on an Angular Service or similar, to make it global to our Angular components.
@soyguijarro soyguijarro added this to the FilmViz - MBP❤ (Minimum Beautiful Product) milestone Jul 28, 2015
@Roboe Roboe modified the milestones: FilmViz - MBP❤ (Minimum Beautiful Product), FilmViz - MBP✂ (Minimum Basic Product) Aug 3, 2015
Roboe added a commit to Roboe/filmviz that referenced this issue Aug 13, 2015
@Roboe
Use strict. Fix FilmViz#47
91a4ce0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CORE enhancement
Projects
None yet
Milestone
MBP✂ (Min Basic Product)
Development

No branches or pull requests
2 participants
@soyguijarro @Roboe