Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for workspaces, bring back in npm i skip #239

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Fix for workspaces, bring back in npm i skip #239

wants to merge 8 commits into from

Conversation

jamesdaniels
Copy link
Collaborator

@jamesdaniels jamesdaniels commented Aug 6, 2024 •
edited
Loading

Found the root cause of the firebase-frameworks issues, the NPM workspaces were defined incorrectly.

  • Fix the NPM workspaces, drop the unnecessary "/*"
  • Bring back in the install skip step, saving 1m on CI/CD runs
  • Add Node 22, allowed failure
  • Add some comments RE node versions
  • Specify Node 20 for lint, check-latest false
  • Update lru-cache as @types/lru-cache is deprecated and causing issues

@jamesdaniels jamesdaniels marked this pull request as ready for review August 6, 2024 15:33
@jamesdaniels jamesdaniels marked this pull request as draft August 6, 2024 15:46
@jamesdaniels
Copy link
Collaborator Author

Ok seems the problem with lru-cache still exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoortizz leoortizz Awaiting requested review from leoortizz leoortizz is a code owner

@Yuangwang Yuangwang Awaiting requested review from Yuangwang Yuangwang is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesdaniels