Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Invalid services.json doesn't throw error #392

Open
colin969 opened this issue Jan 18, 2023 · 0 comments
Open

[BUG] Invalid services.json doesn't throw error #392

colin969 opened this issue Jan 18, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@colin969
Copy link
Member

Describe the bug
If the services.json is not valid JSON, it fails to load but fails to produce an error to the user, being an efficiently invisible failure.

Expected behavior
Give some kind of indication that the services file failed to parse
@colin969 colin969 added the bug Something isn't working label Jan 18, 2023
@colin969 colin969 added the good first issue Good for newcomers label Jul 31, 2024
dot-mike added a commit to dot-mike/launcher that referenced this issue Dec 14, 2024
@dot-mike
feat: add error message for service loading failures.
0878c24 
This fixes FlashpointProject#392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colin969