Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Keyboard shortcuts for zooming in and out don't work as expected #437

Open
n0samu opened this issue Nov 21, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@n0samu
Copy link
Member

n0samu commented Nov 21, 2024

Describe the bug
The Ctrl - keyboard shortcut reduces the launcher's zoom level, but Ctrl + does not zoom in unless the Shift key is held down. I guess that makes sense because you need to hold the shift key to type the + character, but this is inconvenient and goes against the convention used in other apps.

Also, when you zoom in and out using the keyboard shortcuts, the restrictions of the zoom bar are not enforced. So you can keep zooming out to under 40% and keep zooming in to over 160%. Worse, if you zoom out too far, the launcher crashes.

Expected behavior

  • Ctrl + should zoom in; you shouldn't need to hold the Shift key.
  • You shouldn't be able to use keyboard shortcuts to set the zoom level outside the normal limits (40% to 160%).

Desktop (please complete the following information):

  • OS: Windows 10
  • Flashpoint Version: 13
@n0samu n0samu added the bug Something isn't working label Nov 21, 2024
@dot-mike
Copy link
Member

I'm not able reproduce this issue. Keybind ctrl + works for me on Windows.

@n0samu
Copy link
Member Author

n0samu commented Nov 28, 2024

I'm using a laptop keyboard with the same layout as this one: https://laptopkeys.com/uploads/2132_1495763532_M123.jpg
Notice that the only way to type the + character on this keyboard is to hold shift while pressing the = key.

dot-mike added a commit to dot-mike/launcher that referenced this issue Dec 14, 2024
dot-mike added a commit to dot-mike/launcher that referenced this issue Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants