Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text: target="_blank" gets stripped from injected HTML values #1464

Open
joepavitt opened this issue Nov 13, 2024 · 1 comment · May be fixed by #1466
Open

Text: target="_blank" gets stripped from injected HTML values #1464

joepavitt opened this issue Nov 13, 2024 · 1 comment · May be fixed by #1466
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do

Comments

@joepavitt
Copy link
Collaborator

Current Behavior

  • The rendered <a /> has the target="_blank" removed.
  • Adding other attributes is fine, it's just the target that seems to get stripped.

Expected Behavior

  • If the HTML has attributes, such as target defined, these should not be stripped.

Steps To Reproduce

Copy the example from our docs, inject it into a UI Text under msg.payload

Environment

  • Dashboard version: 1.19.1
  • Node-RED version: 4.x

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@joepavitt joepavitt added bug Something isn't working needs-triage Needs looking at to decide what to do labels Nov 13, 2024
@joepavitt joepavitt moved this from Backlog to Up Next in Dashboard Backlog Nov 13, 2024
@m-schaeffler
Copy link
Contributor

I have similar code in my project and just tested it: Issue also reproduced here.

@bartbutenaers bartbutenaers linked a pull request Nov 13, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do
Projects
Status: Up Next
Development

Successfully merging a pull request may close this issue.

2 participants