Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support internal HTTPS for WYSIWYG #1480

Closed
wants to merge 1 commit into from

Conversation

Steve-Mcl
Copy link
Contributor

closes #1473

Description

  • Checks RED.settings.requireHttps and switches the URL scheme to "https://"
  • Also, if RED.settings.https is "something", apply an HTTPS agent too
    • (this bit i am not 100% sure about - might be just as well to apply the agent regardless of RED.settings.https) - lets see how it goes, it solves the OPs current issue)

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue Nov 19, 2024 that may be closed by this pull request
@Steve-Mcl Steve-Mcl requested a review from joepavitt November 19, 2024 15:08
@Steve-Mcl
Copy link
Contributor Author

after further consideration, I am closing this in favour of a new PR (incoming) change based off the wysiwyg work in #1469 which had to change axios promise chain to async await.

This is to both avoid having a merge conflict AND the fact I was not checking the right thing to determined a HTTPS scheme was required. In short, Node-RED listens on HTTPS when RED.settings.https is set to "something" not the presence of the flag requireHttps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 error when layout editor attempts to save changes
1 participant