Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callbacks Quality of Life improvements #98

Open
lorenzoh opened this issue Feb 23, 2022 · 0 comments
Open

Callbacks Quality of Life improvements #98

lorenzoh opened this issue Feb 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@lorenzoh
Copy link
Member

lorenzoh commented Feb 23, 2022

Collecting some nice-to-have changes to callbacks. Some of these are breaking so they should be part of the next minor release.

  • CustomCallback: Pass event and phase through to the wrapped function. Not having access to this information is unnecessarily limiting. BREAKING
  • ToDevice: Change default behavior so that every array that is in state at StepBegin is moved. Add option to only move specific keys. This is a good default when implementing custom training Phases, as the current implementations assumes there are always xs and ys (this is from before the new training loop API was introduced). BREAKING
@lorenzoh lorenzoh added the enhancement New feature or request label Feb 23, 2022
@lorenzoh lorenzoh changed the title Callback of Quality of Life improvements Callbacks Quality of Life improvements Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant