Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #1467

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fix tests #1467

merged 2 commits into from
Oct 26, 2023

Conversation

devmotion
Copy link
Collaborator

@devmotion devmotion commented Oct 25, 2023

Fixes of the tests for FluxML/ZygoteRules.jl#26. See #1466.

Fixes a test.

@ToucheSir ToucheSir closed this Oct 25, 2023
@ToucheSir ToucheSir reopened this Oct 25, 2023
test/gradcheck.jl Outdated Show resolved Hide resolved
test/structures.jl Outdated Show resolved Hide resolved
@devmotion
Copy link
Collaborator Author

Seems #1328 "fixed" all but one test error.

@devmotion devmotion merged commit 0ac130f into master Oct 26, 2023
9 of 12 checks passed
@devmotion devmotion deleted the dw/nothing branch October 26, 2023 08:57
@devmotion
Copy link
Collaborator Author

Flux test failure indicates that the latest Zygote release fixed a test that is currently marked as broken. Should be fixed by FluxML/Flux.jl#2349.

@devmotion
Copy link
Collaborator Author

😅 I implicitly assumed that the ZygoteRules PR had been merged due to existence of ZygoteRules 0.2.4. But it seems this new release just contains the additional downstream tests. So possibly the two other fixes in the PR that I reverted are still needed once the ZygoteRules PR is actually merged an released.

@devmotion devmotion changed the title Fix tests for ZygoteRule change Fix tests Oct 26, 2023
@ToucheSir
Copy link
Member

That was my bad, I thought it was merged too and tagged a release! I agree with your idea in #1466 (comment), just need a quick sanity check from someone else before we start merging and updating the Zygote interface too.

Pangoraw pushed a commit to Pangoraw/Zygote.jl that referenced this pull request Dec 4, 2023
* Fix tests for ZygoteRule change

* Apply suggestions from code review
Pangoraw pushed a commit to Pangoraw/Zygote.jl that referenced this pull request Dec 4, 2023
* Fix tests for ZygoteRule change

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants