-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #1467
Fix tests #1467
Conversation
Seems #1328 "fixed" all but one test error. |
Flux test failure indicates that the latest Zygote release fixed a test that is currently marked as broken. Should be fixed by FluxML/Flux.jl#2349. |
😅 I implicitly assumed that the ZygoteRules PR had been merged due to existence of ZygoteRules 0.2.4. But it seems this new release just contains the additional downstream tests. So possibly the two other fixes in the PR that I reverted are still needed once the ZygoteRules PR is actually merged an released. |
That was my bad, I thought it was merged too and tagged a release! I agree with your idea in #1466 (comment), just need a quick sanity check from someone else before we start merging and updating the Zygote interface too. |
* Fix tests for ZygoteRule change * Apply suggestions from code review
* Fix tests for ZygoteRule change * Apply suggestions from code review
Fixes of the tests for FluxML/ZygoteRules.jl#26. See #1466.Fixes a test.