Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Better l10n support #70

Open
Albirew opened this issue Jul 2, 2017 · 1 comment
Open

Better l10n support #70

Albirew opened this issue Jul 2, 2017 · 1 comment

Comments

@Albirew
Copy link

Albirew commented Jul 2, 2017

Is it possible to change these lines to make them easily translatable in a separate language file?:

\content\themes\default\views\read.php

  • Line 108: var gt_key_suggestion = '<?php echo addslashes(_("Use W-A-S-D or the arrow keys to navigate")) ?>';
  • Line 109: var gt_key_tap = '<?php echo addslashes(_("Double-tap to change page")) ?>';
  • Line 197: create_message('is_spread', 3000, 'Tap the arrows twice to change page');

content\themes\default\views\latest.php

  • Line 26: <div class="meta_r">' . _('by') . ' ' . $chapter->team_url() . ', ' . $chapter->date() . ' ' . $chapter->edit_url() . '</div>

content\themes\default\views\comic.php

  • Line 16: <?php if ($comic->author) : ?><?php echo '<b>'._('Author').'</b>: '.$comic->author; ?><br><?php endif; ?>
  • Line 17: <?php if ($comic->artist) : ?><?php echo '<b>'._('Artist').'</b>: '.$comic->artist; ?><br><?php endif; ?>
  • Line 45: echo '<div class="title">'._('Chapters').'</div>';
  • Line 51: <div class="meta_r">' . _('by') . ' ' . $chapter->team_url() . ', ' . $chapter->date() . ' ' . $chapter->edit_url() . '</div>

content\themes\default\views\adult.php

  • Line 9: <?php echo _('This series contains mature contents and is meant to be viewed by an adult audience.<br/> If you are of legal age, click on continue.'); ?>
  • Line 12: <a href="<?php echo site_url() ?>">Back to index</a> or
  • Line 15: echo form_submit('', _('Continue'));

application\models\chapter.php
too much lines, basically every set_notice, a few echo and return, and strings from function help_lang()

I may have forgot some but if these strings were translatable, maintenance and update would be extra-easier.

@oohnoitz
Copy link
Contributor

oohnoitz commented Jul 2, 2017

AFAIK, it should be possible but would require quite a bit of work to implement it.

This is a bit of a CANNED response, but we don't have any plans on doing it though and will welcome any PR submitted for this implementation. There hasn't been any motivation to maintain this code base for various reasons (lack of motivation, time, etc). So I wouldn't put much hopes on any future development with this code base. It is possible that we might rewrite the entire project in a more modern framework, but there aren't any guarantees on that. Open for thoughts/ideas/collaboration to an extent though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants