CI requirements update (macOS, GeoClaw netCDF) #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC-11 is being removed from GitHub Actions macOS runners in a few weeks actions/runner-images#10213
|
I would prefer if GeoClaw didn't require NETCDF. We rarely use it and so do not require it. |
|
Netcdf is not a required library at all. Things should be able to work without it. |
|
The problem is probably related to geoclaw needing preprocessing for the fortran source files |
scottaiton
reviewed
Jul 23, 2024
|
|
||
| "configurePresets": [ | ||
| { | ||
| "name": "ci", | ||
| "binaryDir": "${sourceDir}/build", | ||
| "generator": "Ninja", |
There was a problem hiding this comment.
Please stop removing Ninja as the ci generator. We need it for Geoclaw since it makes heavy use of f90 modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: macos: update GCC version.
GeoClaw now requires netCDF.
Simplify CMake presets.
GCC-11 is being removed from GitHub Actions macOS runners in August 2024.
actions/runner-images#10213