Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Enable/Allow faceId touchid or any biometric action before redirect or close the modal/webview #978

Open
lguardado opened this issue May 20, 2024 · 6 comments

Comments

@lguardado
Copy link

Issue

Hi everyone.

I was wondering if it would be possible, after entering valid credentials and getting the token, to give the user some time in iOS to be able to save the credentials before closing the webview/modal.

If not, could someone point me in the right direction to try to do it myself in any of the library files?
I was trying to do it with the following files, but I couldn't find the right spot to, for instance add some kind of timeout so the user is able to tap in "save credentials" after the credentials are validated and before the modal is closed.

node_modules/react-native-app-auth/ios/RNAppAuth.m
ios/Pods/AppAuth/Sources/AppAuthCore/OIDAuthorizationService.m
ios/Pods/AppAuth/Sources/AppAuthCore/OIDAuthState.m
ios/Pods/AppAuth/Sources/AppAuthCore/OIDAuthorizationRequest.m

Thanks in advance!


Environment

Azure
iOS
react-native Version**: 0.73.6
react-native-app-auth Version: ^7.1.0

  • Are you using Expo? NO
@lguardado
Copy link
Author

hi! has anyone experienced this or has an idea of where can I take a look? thanks!

@carbonrobot
Copy link
Contributor

The users enter credentials on the authentication sites of the configured providers. At that point in time, the user is not executing code from this library, so there isn't any hook you can use in this library to do so.

@lguardado
Copy link
Author

Hi, thank you for your answer. I understand that opening and closing the webView is being executed precisely by this library. Closing it after redirect is the part I'm trying to avoid

The users enter credentials on the authentication sites of the configured providers. At that point in time, the user is not executing code from this library, so there isn't any hook you can use in this library to do so.

@anehustorov
Copy link

@lguardado hey, did you find a solution for this?

@lguardado
Copy link
Author

@lguardado hey, did you find a solution for this?

hey @anehustorov sorry for the late response, I didn't get notified about your comment. Not really I didn't have the chance to continue investigating, but I believe it should be possible to do

@lguardado
Copy link
Author

hi @anehustorov, did you attempt to fix this too by any chance? I reassumed working on this and having some clue would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants