Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inadvertently creating duplicate birthday events when importing birthdays from contacts #206

Closed
7 tasks done
vivident4004 opened this issue Apr 10, 2024 · 4 comments
Closed
7 tasks done
Labels
invalid This does not seem right

Comments

@vivident4004
Copy link

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.3

Affected Android/Custom ROM version

Android 14

Affected device model

All

How did you install the app?

GitHub releases

Steps to reproduce the bug

  1. Go to app's main menu
  2. Tap on "add birthdays from contacts"

Expected behavior

The event for the birtdays would be added only once, and the duplicates would not be added or would be merged. So, if one taps n times the import button at any n moments, there should still be only one event of each birthday for every contact.

Actual behavior

For every contact there are n events created (with n taps on the import button), and there is not a way, or a button, or a setting to automatically merge all birthdays for all contacts for every year in the calendar.

Screenshots/Screen recordings

No response

Additional information

The only way to solve this is to delete the birthdays event tab completely and re-import all the birthdays, which is slightly inconvenient. It would be nice if there was a simple check to prevent this behaviour from happening.
Also, I haven't tried with anniversaries or other types of events, but I suspect the behaviour might be the same.

@vivident4004 vivident4004 added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Apr 10, 2024
@Aga-C
Copy link
Member

Aga-C commented Apr 10, 2024

Add contact birthdays should prevent duplicates from being created. I tested it right now, and no duplicate entries have been created.

Where do you store your contacts? Do you modify contacts in any way between imports?

Also, please provide your specific device model.

@Aga-C Aga-C added question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Apr 10, 2024
@vivident4004
Copy link
Author

I've now retested the app and indeed, no duplicates appear.
I recently moved all of my data to another phone, and on the previous phone I was using SimpleMobileTools' Calendar, and I imported all the events through a .ics backup on the new Fossify Calendar, so I guess there was a mismatch and the new app didn't properly recognize the birthday events. Now, after deleting the birthdays tab and re-importing them, no duplicates appear. I even tried adding a new birthday to a contact, and after tapping again on Add contact birthdays, it gets automatically imported with no duplicates.

My bad, I should've tested it more thoroughly. Should I cancel this bug report?

The only bug now, if we can classify it as that, is after removing the birthday from a contact (in this case, the contact I modified for the test) it is not automatically removed from the calendar, even after tapping again on Add contact birthdays.

I have the stock contacts app on a Pixel 8.

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Apr 10, 2024
@Aga-C
Copy link
Member

Aga-C commented Apr 10, 2024

after removing the birthday from a contact (in this case, the contact I modified for the test) it is not automatically removed from the calendar, even after tapping again on Add contact birthdays

There's already a similar issue: #194, so we are aware that this synchronization needs a refinement.

@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@Aga-C Aga-C added invalid This does not seem right and removed bug Something is not working question Further information is requested needs triage Issue is not yet ready for PR authors to take up labels Apr 10, 2024
@Satlinker
Copy link

Satlinker commented Nov 29, 2024

Similar problem with teracube and iode-os.
I sync a nextcloud birthday calendar over CalDav. The birthdays appear twice in fossify. On PC they appear right, once in my thunderbird calendar.
If I delete the birthdays in fossify, they reappear twice. This should be right, because the nextcloud calendar is write-protected.
I cannot find any option to remove birthdays from contacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This does not seem right
Projects
None yet
Development

No branches or pull requests

3 participants