Fix no notification permission issue

[austinoneil]

What is it?

• Bugfix
• Feature
• Codebase improvement

Description of the changes in your PR

• Fix issue when user could not add an event/task when notification permission was not granted.
• Refactored some logic, extracting reused code into a reusable function.

Before/After Screenshots/Screen Record

• Before:
• After:

Fixes the following issue(s)

• Fixes Cannot take off alarm without adding notification permission #220

Acknowledgement

• I read the contribution guidelines.

[Aga-C]

It should ask for the permission at least on the first app startup. Most people won't think about turning manually the permission. Remember that this app isn't done only for technically advanced users.

[austinoneil]

@Aga-C Good idea. I added a check in the latest commit.

[naveensingh]

This should be replaced with the extension function used in all Fossify apps:

hasPermission(PERMISSION_POST_NOTIFICATIONS)

[naveensingh]

This should be replaced with the extension function used in all Fossify apps:

hasPermission(PERMISSION_POST_NOTIFICATIONS)

[naveensingh]

No, the app shouldn't ask for notification permission right at the startup, previous behavior was the correct behavior. To properly solve the issue of removing reminders without permission, we can try either of these options:

• Add a cross button at the end of reminders fields that users can press to delete a given reminder.
• Make the permission check more intelligent by asking for permission after the user selects anything other than the "No reminder" option. I like this option more.

[fossifybot]

This pull request has been automatically closed due to inactivity. We requested additional information but have not received a response from the original author. Without the requested details, we cannot proceed. If you have the needed information or updates, please reopen the PR or comment so we can continue the review.