Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alarm after beginning of an event #54

Open
5 tasks done
hoergen opened this issue Jan 9, 2024 · 6 comments
Open
5 tasks done

Alarm after beginning of an event #54

hoergen opened this issue Jan 9, 2024 · 6 comments
Labels
feature request Issue is about a new feature in the app

Comments

@hoergen
Copy link

hoergen commented Jan 9, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Is your feature request related to a problem? Please describe.
no

Describe the solution you'd like
Normaly you can set alarms before an event to remind you for that event. I would like to have the option to set alarms after an event has started. The reason is that I so can define a "warning" before an event ends instead of setting up a timer or another event in the event.

So setting up an one hour event with an alarm 10 minutes before and then be able to set 45 minutes after the event starts to set a warning, that the events is close to end soon.

Describe alternatives you've considered
Setting up additional timers with another app

Additional context
the only calender I know that is doing this is Etar. But I would love to use the Fossify Calender because of several other reasons.

@hoergen hoergen added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 9, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 9, 2024
@Mileeam
Copy link

Mileeam commented Jan 30, 2024

Hello, as part of a course (from Université Paris 8) on free software development where I have to make my first contribution to an open-source project, I would like to work on this feature request if it is still available and possible.

@Aga-C
Copy link
Member

Aga-C commented Jan 30, 2024

@Mileeam You're free to work on any issue that doesn't have needs triage label.

@Mileeam
Copy link

Mileeam commented Jan 30, 2024

@Aga-C ok so i am free to work on this one since needs triage label was remove ?

@Aga-C
Copy link
Member

Aga-C commented Jan 30, 2024

@Mileeam Yes.

@woheller69
Copy link

What about simply allowing to enter negative values?

@woheller69
Copy link

woheller69 commented Aug 26, 2024

It works with the following 2 changes:

1.) Fossify Commons library:
Add a "-" after "0123456789" in commons/src/main/res/layout/dialog_custom_interval_picker.xml

            android:id="@+id/dialog_custom_interval_value"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:digits="0123456789-"
            android:inputType="number"
            android:maxLength="5"
            android:textCursorDrawable="@null"

2.) in EventActivity.kt -> saveEvent()
remove this part:

    if (!binding.eventAllDay.isChecked) {
        if ((reminders.getOrNull(2)?.minutes ?: 0) < -1) {
            reminders.removeAt(2)
        }

        if ((reminders.getOrNull(1)?.minutes ?: 0) < -1) {
            reminders.removeAt(1)
        }

        if ((reminders.getOrNull(0)?.minutes ?: 0) < -1) {
            reminders.removeAt(0)
        }
    }

Then reminders after start of the event will be saved.
2 minor issues remain:

  • "-1" minute does not work, because -1 is used for "no reminder". If an event with reminder 1min after start is created with Etar, also "No reminder" is displayed. So that is a bug in my view. We should better use Integer.MIN_VALUE instead of -1
  • the display is wrong. It does not say e.g. "10 minutes after" but "During the day at 00:10".
    But this error is also present if an event is created with a different app like Etar which also supports to enter reminders after start. Nevertheless the alarm works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app
Projects
None yet
Development

No branches or pull requests

4 participants