Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch is broken for Pixel 8 Pro #7

Closed
popogomo opened this issue Dec 15, 2023 · 8 comments · Fixed by #154
Closed

Touch is broken for Pixel 8 Pro #7

popogomo opened this issue Dec 15, 2023 · 8 comments · Fixed by #154
Labels
bug Something is not working device/software specific Issues that only happen on some devices or with some specific hardware/software

Comments

@popogomo
Copy link

As described here: SimpleMobileTools/Simple-Calendar#2277

Multiple other users reported the same issue.

@popogomo popogomo added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Dec 15, 2023
@Aga-C
Copy link
Member

Aga-C commented Dec 15, 2023

Please treat this as a completely new issue and adjust your bug report to the issue template.

We don't know if old issues won't disappear, so it's better to not link to them.

EDIT: Thanks!

@Aga-C Aga-C added device/software specific Issues that only happen on some devices or with some specific hardware/software waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. template missing The bug/feature template is missing and removed waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Dec 15, 2023
@popogomo
Copy link
Author

popogomo commented Dec 25, 2023

@Aga-C


name: Bug report
about: Fix calendar tap issue on Pixel 8 / 8 Pro devices
title: Touch is broken for Pixel 8 Pro
labels: bug, needs triage
assignees: ''


Checklist

  • I can reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Describe the bug

Touch doesn't work properly in the latest version of Calendar (v6.23.1) on Google Pixel 8 Pro running GrapheneOS. For example, in "Monthly and Daily view" the touch recordings are recorded diagonally, e.g. - press on 8th, it will record 7, then press on 15th, it will record 13th, then press on 22, it will record 19th, press 29th. it will record 25th. so going down diagonally from 7 to 25th, etc.

It is not a phone issue as all other apps are working as expected, only this app glitches. Other users also reported the exact same issue on Simple MobileTools Issue tracker. We believe it might be related with Pixel 8 Pro's screen resolution (1344x2992).

To Reproduce
Steps to reproduce the behavior:

  1. Open the the calendar in any view, for example, Monthly View.
  2. Tap to 5th - it will select 4th. Then tap to 16th - it will select 14th, etc. So it doesn't record the taps properly.
  3. If we press and hold the entry (for example, 5th), it will actually highlight the 5th, so it detects we press the 5th, but if we tap 5th, it will still open 4th instead.

This is happening with the out-of-the-box settings.

Expected behavior

Tap should work properly in any view, that is - if we tap to 5th, it should open/select 5th, etc.

Screenshots
Video is provided

Device info (please complete the following information):

  • Model: Pixel 8 Pro
  • OS: GrapheneOS, Android 14
  • Version: 6.23.1
287512301-ba47d11d-792c-452f-936d-b07af4ab5c6b.mp4

@Aga-C Aga-C removed needs triage Issue is not yet ready for PR authors to take up template missing The bug/feature template is missing labels Dec 25, 2023
@m4teh
Copy link

m4teh commented Jan 8, 2024

Yep same. Needs fixing for sure.

@popogomo
Copy link
Author

Folks, do you have any estimates on this by a chance? Thanks.

@Doc-4
Copy link

Doc-4 commented Jan 31, 2024

Can report that I also have this bug with the exact same environment.

@m4teh
Copy link

m4teh commented Feb 1, 2024

Forced to move to Etar, which is unfortunate.
Even manual entry with specific dates places it in a completely random other date. Completely unusable on Pixel 8/pro

@jonas-w
Copy link
Contributor

jonas-w commented Feb 18, 2024

I found the bug and opened a PR #154 , the problem was that the screen width is exactly divisible by 7 (days per week / columns) and it checked if the element fits onto the screen by doing a "less than" comparison instead of a "less or equals" so it wrapped the last element into a new line.

@popogomo
Copy link
Author

I found the bug and opened a PR #154 , the problem was that the screen width is exactly divisible by 7 (days per week / columns) and it checked if the element fits onto the screen by doing a "less than" comparison instead of a "less or equals" so it wrapped the last element into a new line.

Thanks a million for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working device/software specific Issues that only happen on some devices or with some specific hardware/software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants