-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducible Builds #1395
Comments
Hi @keraliss, Could you please use version 3.19 and try again? You can refer to our Docker file to find the correct package version required for the build: DockerFile. |
Sure, thanks for the response, will try with 3.19 and revert back! |
hey, update for envoy, i tried build from the docker file and run the container. The build was successful, it runs as well, but was unable to generate an apk despite my efforts. would highly appreciate if you can let me know how you guys generate the apks, so i can replicate that! Thanks in advance! |
heyy, quick update, we were able to build the apk, and compared it with the official app we got from play store. we found a significant diff,
There were around 1000+ more lines of diff containing png, webp and xml changes. Would be great if you can look into it! |
Did you build it by running Please tell us how you built and we'll resolve this in no time |
Hello @icota 😊, Danny here from walletscrutiny as well. I was revisiting this issue and noticed something.
What did work for me was to execute:
Here are the steps I undertook to build the app:
From there we will run a diff -r on the matching sets of split apks. (ie. arm64_v8a vs arm64_v8a) arm64_v8a diffs
Summarized, the diffs for arm64_v8a are:
With the AndroidManifest.xml, the META-INF, and stamp-cert-sha256 as signing-related. en diffs:Summary:
xxhdpi diffs:Summary:
master diffs:
I do believe we're getting closer, now that we've eliminated many hundreds or thousands of diffs. The build log: Running the diffs are in another terminal session, which I was not able to record. |
There is no container because it seems you don't have a docker install. Can you install docker and try again please? I would prefer if we could get the same artifacts before we diff. A docker build will make sure we are using the same versions of Flutter, NDK, Java, etc |
Alright, will do again tomorrow - different timezones. Thank you sir. Addendum:
|
So some updates: diff master
diff en
diff arm64_v8a
diff xxhdpi
I will give it another try tomorrow, thanks again. Good day! :) |
Thank you @xrviv! We are now looking specifically into the binary diffs that you found. They are to do with our Rust libraries. We might be missing certain flags that are necessary for binary equivalence. Will keep you posted here and thanks again. |
You're most welcome. And thank you for the prompt responses. I did another round for this app, this time through: Build through 'just docker-build-android' for version 1.8.4https://asciinema.org/a/691653
We then process the diffsDifferences found between /tmp/test_com.foundationdevices.envoy_1.8.4/fromPlay-unzipped/arm64_v8a and /tmp/test_com.foundationdevices.envoy_1.8.4/fromBuild-unzipped/arm64_v8a
Differences found between /tmp/test_com.foundationdevices.envoy_1.8.4/fromPlay-unzipped/en and /tmp/test_com.foundationdevices.envoy_1.8.4/fromBuild-unzipped/en
Differences found between /tmp/test_com.foundationdevices.envoy_1.8.4/fromPlay-unzipped/xxhdpi and /tmp/test_com.foundationdevices.envoy_1.8.4/fromBuild-unzipped/xxhdpi
Differences found between /tmp/test_com.foundationdevices.envoy_1.8.4/fromPlay-unzipped/base and /tmp/test_com.foundationdevices.envoy_1.8.4/fromBuild-unzipped/base were too large. We uploaded it in a file. |
What mobile OS are you using?
Android
Please provide details on the device you experienced the bug on
Hi, i'm Keraliss from walletscrutiny, i tried to build your app from the dockerfile provided in the repository, but it resulted in this error -
Description
As the build from provided dockerfile failed, we created our own dockerfile based on the one provided. This is the dockerfile
And this is the
com.foundationdevices.envoy.build_ffi_android.sh
filePlease provide the steps that you've used to reproduce the issue
Docker Build and Run Commands:
the build was successful
Then we tried to run the container
And got this
If applicable, add screenshots or screen recordings to help explain the issue.
No response
If applicable, add logs to help us diagnose the issue.
No response
Anything else?
Issues Encountered:
OpenSSL Build Failure:
The build process for OpenSSL failed with the following error:
This indicates potential issues with missing tools or incorrect configuration for building OpenSSL.
Flutter Dependency Conflict:
There is a version conflict with the
intl
package. The project specifiesintl ^0.18.0
, but the Flutter SDK requiresintl 0.19.0
due to dependencies likeflutter_localizations
. This conflict prevents the successful build of the APK. The specific error encountered was:Attempts to resolve this by updating the
intl
version in thepubspec.yaml
file led to further issues:Can anyone suggest on how to fix this?
Impact of the issue
None
If you found any similar or related issues, provide links to them here.
n/a
The text was updated successfully, but these errors were encountered: