Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetMaintenanceZone() method doesn't work #1901

Open
johscheuer opened this issue Dec 6, 2023 · 1 comment
Open

GetMaintenanceZone() method doesn't work #1901

johscheuer opened this issue Dec 6, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@johscheuer
Copy link
Member

What happened?

Currently the method in https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/fdbclient/admin_client.go#L353-L361 doesn't return the correct result, as the key is incorrect. As long as the operator caches the status, this is not problematic (default behaviour). Only if a user makes use of this method directly they will notice this issue.

We have two options:

  1. Requires the management API (7.1), doing a range read:
Range limited to 10000 keys
`\xff\xff/management/maintenance/testing' is `59999743'
  1. Reading the healthyZone and decoding the value:
fdb> get \xff\x02/healthyZone
`\xff\x02/healthyZone' is `\x01\x00\x01b\xb0\x00\xdb\x0f\x07\x00\x00\x00testingy\xd3\x8a\xf3\x10<\x00\x00'

What did you expect to happen?

The method should return the current maintenance zone if active.

How can we reproduce it (as minimally and precisely as possible)?

Use the method mentioned above.

Anything else we need to know?

FDB Kubernetes operator

$ kubectl fdb version
# paste output here

Kubernetes version

$ kubectl version
# paste output here

Cloud provider

@johscheuer johscheuer added the bug Something isn't working label Dec 6, 2023
@johscheuer johscheuer self-assigned this Dec 6, 2023
@johscheuer
Copy link
Member Author

We will wait until we have 7.1 as the minimum version and then take the approach with the management API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant