Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI Method - Automatic TX Type Checking Makes Sense #27

Open
mangoplane opened this issue Jun 7, 2023 · 1 comment
Open

ABI Method - Automatic TX Type Checking Makes Sense #27

mangoplane opened this issue Jun 7, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mangoplane
Copy link

mangoplane commented Jun 7, 2023

For ABI methods overloaded with a particular type of TX reference, say AssetTransferTransactionReference, I believe it should unmarshall to handle the type checking automatically. I really can't see a reason why this flexibility might not be desired. Maybe the default transaction reference, TransactionReference can be a bare bones flexible transaction handler for a case where the dev wants to break out of the flow.

              string txTypeCheck = "axfer";
            if (txn.TxType != txTypeCheck.ToByteArray()) return 0;

Kind regards.

@FrankSzendzielarz
Copy link
Owner

Agreed. This functionality is not there simply because it wasnt in the roadmap prior and wasnt sure if the preference would be to have the plumbing do it for us or not. Will tag as feature request

@FrankSzendzielarz FrankSzendzielarz self-assigned this Mar 12, 2024
@FrankSzendzielarz FrankSzendzielarz added the enhancement New feature or request label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants