Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit page: grey out submit button until conditions met #138

Open
sckott opened this issue Sep 19, 2024 · 2 comments
Open

Submit page: grey out submit button until conditions met #138

sckott opened this issue Sep 19, 2024 · 2 comments
Assignees
Labels
medium priority Important but not urgent, implement soon v1.2 Should be implemented in PROOF v1.2

Comments

@sckott
Copy link
Collaborator

sckott commented Sep 19, 2024

via a @codebeaker study

She suggested greying out the Submit button on the Submit page unless conditions met, those in my mind would be:

  • WDL file upload complete
  • if we want to require labels, then also make sure there's labels

On Reset button click back to greyed out

grey out == disable

@tefirman
Copy link
Collaborator

Love this idea, also feel like it would be useful for the "Validate" tab, but less important. Let's make sure not to include an input json as a requirement though, it's definitely possible (although rare) for WDL's to run without inputs.

@tefirman tefirman added medium priority Important but not urgent, implement soon v1.2 Should be implemented in PROOF v1.2 labels Oct 10, 2024
@sckott
Copy link
Collaborator Author

sckott commented Oct 10, 2024

Let's make sure not to include an input json as a requirement though

will do

@sckott sckott self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Important but not urgent, implement soon v1.2 Should be implemented in PROOF v1.2
Projects
None yet
Development

No branches or pull requests

2 participants