Help: Added basic unit tests and minor fixes #12635
Draft
+153
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorikvanhavre
force-pushed
the
help-tests
branch
2 times, most recently
from
0f994cb
to
77ad301
Compare
- Adds unit tests to test for the different modes of the Help module - Allow to launch Help from Python forcing the mode (dialog, tab or ext browser) - Removed the use of the Web module (still available by setting a pref parameter) - Better text output when used in non-GUI mode
yorikvanhavre
force-pushed
the
help-tests
branch
from
37c9023
to
2ce9a94
Compare
yorikvanhavre
force-pushed
the
help-tests
branch
from
fa21ce3
to
a9c3831
Compare
for more information, see https://pre-commit.ci
|
@yorikvanhavre what is left to do here? |
|
This needs to be reworked a lot because it contained workarounds for bad Qt5 versions, that hopefully we're done with now. I'll have a look at it ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a series of small fixes to the Help module:
Fixes FreeCAD/FreeCAD-Help#22