-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch statemachine to work with example #1663
Open
tmcguc
wants to merge
4
commits into
FreeOpcUa:master
Choose a base branch
from
tmcguc:patch-statemachine
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−2
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
From 7a5311b4f1094dff434df43acc46ead4d1b2d7a0 Mon Sep 17 00:00:00 2001 | ||
From: Dr Terrence McGuckin <[email protected]> | ||
Date: Wed, 19 Jun 2024 18:55:18 -0400 | ||
Subject: [PATCH] changed sytate machine to work with example | ||
|
||
--- | ||
asyncua/common/statemachine.py | 6 ++++-- | ||
1 file changed, 4 insertions(+), 2 deletions(-) | ||
|
||
diff --git a/asyncua/common/statemachine.py b/asyncua/common/statemachine.py | ||
index 37fcf6e..943da74 100644 | ||
--- a/asyncua/common/statemachine.py | ||
+++ b/asyncua/common/statemachine.py | ||
@@ -203,7 +203,8 @@ class StateMachine(object): | ||
await self._current_state_node.write_value(ua.LocalizedText(state.name, self.locale), ua.VariantType.LocalizedText) | ||
if state.node: | ||
if self._current_state_id_node: | ||
- await self._current_state_id_node.write_value(state.node.nodeid, varianttype=ua.VariantType.NodeId) | ||
+ await self._current_state_id_node.write_value(state.name,ua.VariantType.String) | ||
+ #await self._current_state_id_node.write_value(state.node.nodeid, varianttype=ua.VariantType.NodeId) | ||
if self._current_state_name_node and state.name: | ||
await self._current_state_name_node.write_value(state.name, ua.VariantType.QualifiedName) | ||
if self._current_state_number_node and state.number: | ||
@@ -222,7 +223,8 @@ class StateMachine(object): | ||
await self._last_transition_node.write_value(ua.LocalizedText(transition.name, self.locale), ua.VariantType.LocalizedText) | ||
if self._optionals: | ||
if self._last_transition_id_node: | ||
- await self._last_transition_id_node.write_value(transition.node.nodeid, varianttype=ua.VariantType.NodeId) | ||
+ await self._last_transition_id_node.write_value(transition.name, ua.VariantType.String) | ||
+ #await self._last_transition_id_node.write_value(transition.node.nodeid, varianttype=ua.VariantType.NodeId) | ||
if self._last_transition_name_node and transition.name: | ||
await self._last_transition_name_node.write_value(ua.QualifiedName(transition.name, self._idx), ua.VariantType.QualifiedName) | ||
if self._last_transition_number_node and transition.number: | ||
-- | ||
2.34.1 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is that file?