-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Fullscreen Mode Tweaks #2606
Fixed: Fullscreen Mode Tweaks #2606
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@DreadKnight, Please review this PR. |
@DreadKnight, I test all browsers. Error is fixed |
I've tested and no luck. Perhaps this is different based on operating system. I'm on linux. |
@aliraza556 Too bad... code does look good. |
I am used window |
Please check demo: https://www.loom.com/share/f3b7b5b0c83047d2946683134e89f958 |
@DreadKnight, when I click |
I don't understand much from the demo as it involves hotkeys and such. |
@DreadKnight, what exactly do you want? Do you want a fullscreen button for the game, and then pressing the Esc key will exit fullscreen mode? |
@aliraza556 The whole idea with this is to not have Esc leave fullscreen, because that's the exact generic browser stuff that we're trying to avoid. |
@DreadKnight Ok got it. |
@DreadKnight, Please test |
@aliraza556 Tested. No go, Esc still leaves fullscreen. Only way to not leave it is by pressing F11, hence why the idea was to emulate triggering that with the fullscreen button. |
537c78b
to
67fb2c7
Compare
67fb2c7
to
42528ac
Compare
Problem:
closes: #2603
Issue ticket number and link:
My wallet address is 0x0000000000000000000000000000000000000000
Will add the wallet address soon