Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension StickyFeed #124

Open
Grishkaone opened this issue Jan 3, 2022 · 8 comments
Open

Extension StickyFeed #124

Grishkaone opened this issue Jan 3, 2022 · 8 comments
Labels
xExtension-StickyFeeds xExtension-StickyFeeds

Comments

@Grishkaone
Copy link

Hello !

I've found a little bug in the Sticky Feeds extension. When using a web browser to access my FreshRSS installation, I can use Safari or Firefox :

Safari / extension off

In this configuration, the left bar (feeds tree) scrolls out of sight with the content.

Safari.-.extension.OFF.mov

Safari / extension on

Here, the menu stay in place. I can scroll inside, or in the content on the right, independently.

Safari.-.extension.ON.mov

Firefox / extension off

The menu stay in place, I can scroll both part independently.

Firefox.-.extension.OFF.mov

Firefox / extension on

This is quite funny actually : when I scroll down on the content side, the feeds menu goes down out of screen entirely. 😂

Firefox.-.extension.ON.mov

So the 1) the behavior is not consistant between browser and extension status and 2) Firefox is going nuts when it's active.
Any idea ?

🖖

@Frenzie
Copy link
Member

Frenzie commented Jan 3, 2022

Pinging @marienfressinaud

@marienfressinaud
Copy link
Member

The StickyFeed is no longer necessary since it's natively supported by FRSS now (this is why it works on Firefox with the extension disabled). I suspect a bug in Safari, maybe this one? https://stackoverflow.com/questions/51792783/safari-positionsticky-not-working-in-an-overflowauto-element

I don't have Safari on my computer so I can't confirm.

@math-GH math-GH changed the title Extension StikckyFeed Extension StickyFeed Jan 3, 2022
@math-GH
Copy link
Contributor

math-GH commented Jan 3, 2022

I can confirm, that in Safari the side navigation does not stick at the top as the Firefox does.

@Frenzie
Copy link
Member

Frenzie commented Jan 3, 2022

You mean at all or with this extension enabled? Because if the latter, well, let's just remove it (probably leaving a deprecated & removed README in there for a while).

@math-GH
Copy link
Contributor

math-GH commented Jan 3, 2022

I tested Safari without this extension.

Summary:
Without extension:
Firefox: Sidebar fixed while scrolling
Safari: Sidebar does not fix while scrolling

@marienfressinaud
Copy link
Member

@math-GH Could you try to add position: -webkit-sticky;? (https://github.com/FreshRSS/FreshRSS/blob/edge/p/themes/base-theme/template.css#L246-L251)

@Grishkaone
Copy link
Author

The -webkit- prefix is normaly not used by Safari 15. I tried with <nav>, the full .aside and .aside.aside_feed elements, even with the .treewithout any success. I also tried without the -webkit- prefix, same result. 😕

@math-GH
Copy link
Contributor

math-GH commented Jan 31, 2024

Sorry, I have not seen the response. I do not have any Mac devices anymore to test it

@math-GH math-GH added the xExtension-StickyFeeds xExtension-StickyFeeds label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xExtension-StickyFeeds xExtension-StickyFeeds
Projects
None yet
Development

No branches or pull requests

4 participants