Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Phone and children #25

Closed
isybuy opened this issue Jan 24, 2024 · 1 comment · Fixed by #26
Closed

add Phone and children #25

isybuy opened this issue Jan 24, 2024 · 1 comment · Fixed by #26

Comments

@isybuy
Copy link
Contributor

isybuy commented Jan 24, 2024

Hello, I'm using your library for my project and the Phone in the Address class doesn't conform to CXml practice, you're sending a string when we need more fields (according to https://xml.cxml.org/current/cXMLReferenceGuide.pdf)

<Phone name="work">
    <TelephoneNumber>
        <CountryCode isoCountryCode="BE" />
        <AreaOrCityCode />
        <Number>1151869655</Number>
    </TelephoneNumber>
</Phone>

Can you add it please ? 😎

@mathielen
Copy link
Collaborator

Hey there!

You're welcome to add a PR with the changes you propose. Happy to merge it :)

@ynnoig ynnoig linked a pull request Jan 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants