Check that discussion/post still exists before attempting to notify (#16

) * Attempting to fix #13 * Ensure discussion still exists before attempting to send notification job * Apply fixes from StyleCI
FriendsOfFlarum · Dec 9, 2020 · ac0cfbc · ac0cfbc
1 parent 661b2c6
commit ac0cfbc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/src/Jobs/SendNotificationWhenDiscussionIsReTagged.php b/src/Jobs/SendNotificationWhenDiscussionIsReTagged.php
@@ -43,6 +43,9 @@ public function __construct(User $actor, Discussion $discussion)
 
     public function handle(NotificationSyncer $notifications)
     {
+        if (!$this->discussion->exists()) {
+            return;
+        }
 
         /**
          * @var Collection

diff --git a/src/Jobs/SendNotificationWhenDiscussionIsStarted.php b/src/Jobs/SendNotificationWhenDiscussionIsStarted.php
@@ -37,6 +37,9 @@ public function __construct(Discussion $discussion)
 
     public function handle(NotificationSyncer $notifications)
     {
+        if (!$this->discussion->exists()) {
+            return;
+        }
 
         /**
          * @var Collection

diff --git a/src/Jobs/SendNotificationWhenReplyIsPosted.php b/src/Jobs/SendNotificationWhenReplyIsPosted.php
@@ -43,6 +43,10 @@ public function __construct(Post $post, int $lastPostNumber)
 
     public function handle(NotificationSyncer $notifications)
     {
+        if (!$this->post->exists()) {
+            return;
+        }
+
         /**
          * @var Collection
          * @var $tagIds    Collection