Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update php cs fixer #338

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Update php cs fixer #338

merged 5 commits into from
Mar 18, 2024

Conversation

thePanz
Copy link
Member

@thePanz thePanz commented Mar 13, 2024

  • Update to v3.51.0
  • Update to use short-array-syntax
  • Run on PHP v7.4 to avoid false edits on higher PHP releases
  • Trigger lint on CI only if relevant files have been changed

@thePanz thePanz merged commit 50a898b into master Mar 18, 2024
5 checks passed
@thePanz thePanz deleted the update-php-cs-fixer branch March 18, 2024 17:10
@thePanz
Copy link
Member Author

thePanz commented Mar 18, 2024

@connorhu does this cover #329 ? Or just partially?

@connorhu
Copy link
Collaborator

partially. "location of violation should be well marked" task is a very complex one. I'm trying to implement the fix in the php-cs-fixer source, but I'm far from a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants