Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypernova SSR not propagating errors correctly #52

Open
rinti opened this issue Aug 15, 2020 · 1 comment
Open

Hypernova SSR not propagating errors correctly #52

rinti opened this issue Aug 15, 2020 · 1 comment
Assignees
Labels

Comments

@rinti
Copy link
Member

rinti commented Aug 15, 2020

This problem might be with hypernova-python plugin. The error gets stuck inside "results" and not at the base dictionary. Eventhough I get the response that everything is OK, the SSR failed.

This is a snippet of the JSON returned from https://github.com/ornj/hypernova-python/blob/master/hypernova/__init__.py#L79

{
  "success": True,
  "error": "None",
  "results": {
    "Components.App": {
      "name": "Components.App",
      "html": "None",
      "meta": {

      },
      "duration": 310.156114,
      "statusCode": 500,
      "success": False,
      "error": {
        "name
        ":"
        ReferenceError ",
        "message": "window is not defined",
        "stack": [
          "ReferenceError: window is not defined",
          "at useMediaQuery (/mnt/persist/www/signalisten/shared/ssr/frontend/ssr_frontend/utils/useMediaQ
          uery.js: 37: 25)
        ",
        ]
}
@marteinn
Copy link
Member

Thanks @rinti! Will investigate what the proper Hypernova result should look like and make sure hypernova-python follows that structure.

@marteinn marteinn self-assigned this Aug 16, 2020
@marteinn marteinn added the bug label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants