Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect conversion from Bytes64 to PublicKey #764

Open
xgreenx opened this issue Jun 15, 2024 · 3 comments
Open

Incorrect conversion from Bytes64 to PublicKey #764

xgreenx opened this issue Jun 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Jun 15, 2024

Conversion from Bytes64 to PublicKey here is incorrect. sec1 includes 1 tag byte at the start of point encoding, so a valid uncompressed PublicKey would be 65 bytes. This is assigned low severity because it doesn't seem to be used anywhere.
@Voxelot
Copy link
Member

Voxelot commented Jun 15, 2024

is this related? #551

@Voxelot Voxelot added the bug Something isn't working label Jun 15, 2024
@Dentosal
Copy link
Member

Calling it incorrect is a bit weird; Bytes64 is assumed to be without the tag byte and not in sec1 format.

@MitchTurner
Copy link
Member

Looks like this just requires a little more investigation. Possibly a non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Voxelot @Dentosal @MitchTurner @xgreenx