Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definitions in headers cause linker issues with multiple compilation units #1

Open
vekkuli opened this issue Sep 3, 2022 · 1 comment

Comments

@vekkuli
Copy link

vekkuli commented Sep 3, 2022

If you have multiple compilations units using the library, you get "multiple definitions" linker errors because of the functions defined in the header files, namely events.h. I guess a solution could be to inline those as well.

Off topic:
Great project! I'm glad I ran into this. I was looking for precedence to programming RP2040 async style. I hope the library catches on and keeps getting developed and maintained.

@FunMiles
Copy link
Owner

Sorry I've been away, still doing async coroutines though.
@vekkuli I presume you added a few inline and got it working. You can do a pull request if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants