Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to app editor Fysion if it is installed #265

Merged
merged 7 commits into from
Oct 27, 2024

Conversation

andydotxyz
Copy link
Contributor

If the source is available and the app is installed let it be edited from the bar.

This will be a killer feature for FyshOS release :)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Oct 9, 2024

Pull Request Test Coverage Report for Build 11539734214

Details

  • 18 of 86 (20.93%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 28.108%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/icon/fdo.go 18 19 94.74%
internal/icon/macos.go 0 3 0.0%
modules/status/network.go 0 3 0.0%
internal/ui/baricon.go 0 61 0.0%
Files with Coverage Reduction New Missed Lines %
internal/icon/fdo.go 1 77.59%
internal/ui/baricon.go 1 21.29%
Totals Coverage Status
Change from base Build 11410899784: -0.1%
Covered Lines: 1630
Relevant Lines: 5799

💛 - Coveralls

@andydotxyz
Copy link
Contributor Author

All right, this now gets the source from apps who's metadata says the source is available.
It clones the code and opens the editor :)

@andydotxyz
Copy link
Contributor Author

No comments so landing :)

@andydotxyz andydotxyz merged commit d475dd5 into FyshOS:develop Oct 27, 2024
5 checks passed
@andydotxyz andydotxyz deleted the feature/editormenu branch October 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants