From cdcf6504f372ea8c959a1da488ae12ed27d423ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ljubo=20Nikoli=C4=87?= Date: Tue, 28 May 2024 19:00:42 +0100 Subject: [PATCH] CI: Fix warnings & deprecation messages in the workflows (#241) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### What type of PR is this? CI: Resolve deprecation & warning messages in workflows Enable DependaBot for GitHub actions ### What this PR does / why we need it: Node16 has been out of support since [September 2023](https://github.com/nodejs/Release/#end-of-life-releases). - more info in the [post](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/) ### Which issue(s) this PR fixes: Resolves: https://github.com/G-Research/gr-oss/issues/640 ------------ #### Test results - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197206 It uses external actions `dawidd6/action-download-artifact@246dbf436b23d7c49e21a7ab8204ca9ecd1fe615` which needs tobe # Testing results 🟢 Build JVM - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197205 🟠 Build Python - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197209 __NOTE__ on upstream, this [workflow](https://github.com/G-Research/spark-extension/actions/workflows/build-python.yml) is not run at all 🟢 Build Snapshot - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197204 __NOTE__ on upstream, this [workflow](https://github.com/G-Research/spark-extension/actions/workflows/build-snapshots.yml) is not run at all 🟢 Check - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197212 __NOTE__ this workflow is called from `CI` workflow, it can be verified it's green [here](https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234) 🟢 CI - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234 🟢 Test JVM - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234 __NOTE__ this workflow is called from `CI` workflow, it can be verified it's green [here](https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234) 🟢 Test Python - https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234 __NOTE__ this workflow is called from `CI` workflow, it can be verified it's green [here](https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234) 🟢 Test results - https://github.com/gr-oss-devops/spark-extension/actions/runs/8878086091 --- .github/actions/build-whl/action.yml | 4 ++-- .github/actions/build/action.yml | 2 +- .github/actions/check-compat/action.yml | 2 +- .github/actions/test-jvm/action.yml | 4 ++-- .github/actions/test-python/action.yml | 4 ++-- .github/workflows/build-snapshots.yml | 2 +- .github/workflows/check.yml | 6 +++--- .github/workflows/ci.yml | 2 +- .github/workflows/test-results.yml | 2 +- 9 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/actions/build-whl/action.yml b/.github/actions/build-whl/action.yml index 15c2f0e1..c0a7f309 100644 --- a/.github/actions/build-whl/action.yml +++ b/.github/actions/build-whl/action.yml @@ -36,7 +36,7 @@ runs: - name: Cache Maven packages if: github.event_name != 'merge_group' - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.m2/repository key: ${{ runner.os }}-mvn-build-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }} @@ -44,7 +44,7 @@ runs: - name: Cache Pip packages if: github.event_name != 'merge_group' - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.cache/pip key: ${{ runner.os }}-pip-whl-${{ inputs.python-version }}-${{ inputs.spark-version }} diff --git a/.github/actions/build/action.yml b/.github/actions/build/action.yml index b2095153..187d018d 100644 --- a/.github/actions/build/action.yml +++ b/.github/actions/build/action.yml @@ -30,7 +30,7 @@ runs: - name: Cache Maven packages if: github.event_name != 'merge_group' - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.m2/repository key: ${{ runner.os }}-mvn-build-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }} diff --git a/.github/actions/check-compat/action.yml b/.github/actions/check-compat/action.yml index 049ecc5e..75d778b4 100644 --- a/.github/actions/check-compat/action.yml +++ b/.github/actions/check-compat/action.yml @@ -36,7 +36,7 @@ runs: - name: Cache Maven packages if: github.event_name != 'merge_group' - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.m2/repository key: ${{ runner.os }}-mvn-check-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }} diff --git a/.github/actions/test-jvm/action.yml b/.github/actions/test-jvm/action.yml index e7704023..66466e7c 100644 --- a/.github/actions/test-jvm/action.yml +++ b/.github/actions/test-jvm/action.yml @@ -38,7 +38,7 @@ runs: path: . - name: Cache Spark Binaries - uses: actions/cache@v3 + uses: actions/cache@v4 if: ( ! contains(inputs.spark-version, '-SNAPSHOT') ) with: path: ~/spark @@ -59,7 +59,7 @@ runs: - name: Cache Maven packages if: github.event_name != 'merge_group' - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.m2/repository key: ${{ runner.os }}-mvn-build-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }} diff --git a/.github/actions/test-python/action.yml b/.github/actions/test-python/action.yml index 82a5039d..62436136 100644 --- a/.github/actions/test-python/action.yml +++ b/.github/actions/test-python/action.yml @@ -42,7 +42,7 @@ runs: - name: Cache Maven packages if: github.event_name != 'merge_group' - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.m2/repository key: ${{ runner.os }}-mvn-build-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }} @@ -56,7 +56,7 @@ runs: - name: Cache Pip packages if: github.event_name != 'merge_group' - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.cache/pip key: ${{ runner.os }}-pip-test-${{ inputs.python-version }}-${{ hashFiles(format('python/requirements-{0}_{1}.txt', inputs.spark-compat-version, inputs.scala-compat-version)) }} diff --git a/.github/workflows/build-snapshots.yml b/.github/workflows/build-snapshots.yml index 16e87386..dca7178d 100644 --- a/.github/workflows/build-snapshots.yml +++ b/.github/workflows/build-snapshots.yml @@ -61,7 +61,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Build uses: ./.github/actions/build diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 341070a3..6c93665e 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -10,19 +10,19 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 - name: Cache Maven packages if: github.event_name != 'merge_group' - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.m2/repository key: ${{ runner.os }}-mvn-lint-${{ hashFiles('pom.xml') }} - name: Setup JDK ${{ inputs.java-compat-version }} - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: java-version: '11' distribution: 'zulu' diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2069e73f..85bdb7a3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Upload - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: Event File path: ${{ github.event_path }} diff --git a/.github/workflows/test-results.yml b/.github/workflows/test-results.yml index f061f60e..d0d5ba20 100644 --- a/.github/workflows/test-results.yml +++ b/.github/workflows/test-results.yml @@ -18,7 +18,7 @@ jobs: steps: - name: Download and Extract Artifacts - uses: dawidd6/action-download-artifact@246dbf436b23d7c49e21a7ab8204ca9ecd1fe615 + uses: dawidd6/action-download-artifact@09f2f74827fd3a8607589e5ad7f9398816f540fe with: run_id: ${{ github.event.workflow_run.id }} name: "^Event File$| Test Results "