Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to cause abort exit with error #598

Open
reitzig opened this issue Apr 30, 2020 · 4 comments · May be fixed by #610
Open

Add option to cause abort exit with error #598

reitzig opened this issue Apr 30, 2020 · 4 comments · May be fixed by #610
Labels
bug
Milestone
0.60.9

Comments

@reitzig
Copy link

reitzig commented Apr 30, 2020

Using aspell in shell scripts, we may want to exit the script early depending on how the aspell check turned out.

Exit with success is sensible after the user stepped through the whole file, and also after x-exiting.

However, when b-aborting we would expect an exit with error. Unfortunately, aspell check seems to always exit with success.

Please change this behaviour, or add an option (--abort-is-error?) so users can change the behaviour if needed.
@kevina kevina added this to the 0.60.9 milestone Jul 18, 2020
@kevina
Copy link
Member

kevina commented Jul 18, 2020

I think it makes sense to exit with an error when aborting. I don't see how that can break anything so an option is an overkill.

@kevina kevina linked a pull request Feb 28, 2021 that will close this issue
Open
@nk9
Copy link

nk9 commented Oct 3, 2023 •
edited
Loading

Would really like to use this. Using aspell to check multiple files right now requires you to abort out of all of them in sequence. (See Superuser question.) With tens to hundreds of files this is impractical. Is there anything holding this back from being merged and, ideally, released?

@kevina, out of curiosity, how did you choose the value of 63 as the abort return value?

@kevina
Copy link
Member

kevina commented Oct 10, 2023

Nothing is holding it back, I just need to get to it.

@nk9, I do not remember why I chose 63, but I must have had a reason, so for now I will leave it at 63.

@nk9
Copy link

nk9 commented Jan 1, 2024 •
edited
Loading

Just checking in on this again. :-) Thanks for your work on this project, let me know if I can help test or anything.

Update: Ah, I see this has been assigned a milestone of 0.60.9 which has other outstanding issues still to be resolved. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.60.9
Development

Successfully merging a pull request may close this issue.

Fix 598 GNUAspell/aspell
3 participants
@kevina @nk9 @reitzig