[GT-183] Update code to address comments

GOCDB · Sep 12, 2023 · 287e34b · 287e34b
1 parent 66f0904
commit 287e34b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/config/web_portal/menu.xml b/config/web_portal/menu.xml
@@ -42,11 +42,11 @@
       <link>index.php?Page_Type=Services</link>
     </Services>
 
-    <ViewServiceTypes>
-        <show_on_instance>write_enabled</show_on_instance>
+    <ServiceTypes>
+        <show_on_instance>all</show_on_instance>
         <name>Service Types</name>
         <link>index.php?Page_Type=Service_Types</link>
-    </ViewServiceTypes>
+    </ServiceTypes>
 
     <Scopes>
       <show_on_instance>all</show_on_instance>

diff --git a/config/web_portal/menu.xsd b/config/web_portal/menu.xsd
@@ -15,7 +15,7 @@
         <xs:element name="Sites" type="showType" minOccurs="0"/>
         <xs:element name="ServiceGroups" type="showType" minOccurs="0"/>
         <xs:element name="Services" type="showType" minOccurs="0"/>
-        <xs:element name="ViewServiceTypes" type="showType" minOccurs="0"/>
+        <xs:element name="ServiceTypes" type="showType" minOccurs="0"/>
         <xs:element name="Scopes" type="showType" minOccurs="0"/>
         <xs:element name="RoleActionMappings" type="showType" minOccurs="0"/>
         <xs:element name="AddSite" type="showType" minOccurs="0"/>

diff --git a/htdocs/web_portal/controllers/admin/view_service_type.php b/htdocs/web_portal/controllers/admin/view_service_type.php
@@ -29,9 +29,6 @@ function view_service_type()
     $identifier = Get_User_Principle();
     $user = \Factory::getUserService()->getUserByPrinciple($identifier);
 
-    /**
-     * @var \User $user
-     */
     if ($user != null) {
         $params['isUserAdmin'] = checkUserForAdminCredentials($user);
     }