Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codebase to PHP 7.4 #454

Closed
wants to merge 4 commits into from
Closed

Update codebase to PHP 7.4 #454

wants to merge 4 commits into from

Conversation

gregcorbett
Copy link
Member

Replaces PR #357 as fork has been deleted.

Also integrates fixes for misc PHP 7.4 notices and warnings.

Ian Neilson added 4 commits June 16, 2022 11:50
Post PHP7.4 update
89b33ac 
After update to PHP7.4 but before change
to ORM2.6.
Turn off phpunit PHP Notice exceptions
bfdcb04 
Moving to PHP7.4 generates some Notice reports from the
Doctrine code which cause tests to fail. This can be switched
back on for later ORM versions where this is fixed.
Fix test error shown by move to PHP7.4
83cef44 
As of PHP 7.2.0 count() yields a warning on invalid countable types passed to the value parameter.
Fix misc PHP7.4 Notices and Warnings
7fa053d
@gregcorbett gregcorbett added this to the September 2023 milestone May 9, 2023
@gregcorbett gregcorbett self-assigned this May 9, 2023
@gregcorbett gregcorbett requested a review from a team as a code owner May 9, 2023 07:49
@gregcorbett gregcorbett mentioned this pull request May 9, 2023
Open
@gregcorbett gregcorbett changed the title Update to ORM 2.5 and PHP 7.4 Update codebase to PHP 7.4 May 24, 2023
rowan04
rowan04 reviewed May 24, 2023
View reviewed changes
Copy link
Member

@rowan04 rowan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in every file other than composer.lock are the same as in PR #357.
There is a difference of about 500 additions/deletions between the changes made to composer.lock in this PR and #357, with more changes being made to #357.
#357 also contains changes to composer.json, which is the ORM update to 2.5

@gregcorbett
Copy link
Member Author

The changes in every file other than composer.lock are the same as in PR #357. There is a difference of about 500 additions/deletions between the changes made to composer.lock in this PR and #357, with more changes being made to #357. #357 also contains changes to composer.json, which is the ORM update to 2.5

Thanks Rowan, I'm not to concerned with composer.lock file as there's a git conflict on that file, wo it will have to be regenerated before this PR is merged - at which point it should be in a good state.

@gregcorbett gregcorbett linked an issue Oct 16, 2023 that may be closed by this pull request
controllers/user/register.php will attempt to pre-populate use details from the OIDC token even if the user is using another auth mechanism. #325
Closed
@gregcorbett
Copy link
Member Author

#491 included the codebase changes and the composer.lock changes were incorporated/superceeded into composer-7.4.json. Closing this, partially in favour of #494

@gregcorbett gregcorbett removed this from the September 2023 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowan04 rowan04 rowan04 left review comments

Assignees

@gregcorbett gregcorbett

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gregcorbett @rowan04