Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GT-141] Add support for pre selecting endpoints #473

Conversation

Sae126V
Copy link
Contributor

@Sae126V Sae126V commented Aug 30, 2023

Clean version for #439 .

Case 1: If the user goes to the sites and tries to add recent downtimes. Then the user should be able to see the site, the services, and the endpoints pre-selected. [Pre-Selection enabled]
Case 2: If the user goes to the services and tries to add recent downtimes. Then the user should see the specific service-related endpoints that are pre-selected. [Pre-Selection enabled]
case 3: If the user goes to "Add Downtime" from the left hand menu, no Site should be pre-selected and they should be able to select any Site they have a role over (all Sites for GOCDB admins). [Pre-Selection NOT enabled]

"Resolves #229"

@Sae126V Sae126V requested a review from a team as a code owner August 30, 2023 10:38
@Sae126V Sae126V marked this pull request as draft September 1, 2023 14:24
@Sae126V Sae126V force-pushed the GT-141-Add-Support-to-Pre-select-site,-services-and-endpoints branch from 9830028 to 560ffbd Compare September 13, 2023 08:58
@Sae126V
Copy link
Contributor Author

Sae126V commented Sep 13, 2023

Ready for the review of functionality. @gregcorbett

@gregcorbett
Copy link
Member

Functionality looks good :)

@Sae126V Sae126V force-pushed the GT-141-Add-Support-to-Pre-select-site,-services-and-endpoints branch from 560ffbd to c6bc19b Compare September 14, 2023 11:10
@Sae126V Sae126V requested a review from gregcorbett September 14, 2023 11:10
@Sae126V Sae126V marked this pull request as ready for review September 14, 2023 11:10
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregcorbett
Copy link
Member

rebasing on latest dev

@gregcorbett gregcorbett force-pushed the GT-141-Add-Support-to-Pre-select-site,-services-and-endpoints branch from c6bc19b to 7d2f569 Compare November 29, 2023 11:36
@gregcorbett gregcorbett self-assigned this Nov 29, 2023
@gregcorbett gregcorbett added this to the May 2023 milestone Nov 29, 2023
@gregcorbett gregcorbett merged commit bc68c0b into GOCDB:dev Nov 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GT-141 pre-select site on add downtime page
3 participants