Fix PHP 7.4 MariaDB test, Drop experimental MariaDB tests #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot about the code climate issues |
and about actually testing these changes don't break anything 😋 |
gregcorbett
force-pushed
the
unit_test_php_modern
branch
4 times, most recently
from
ee8efbf to
5db1463
Compare
- they have never worked and our PHP upgrade to 7 is going to be to 7.4 as this is the highest 7.X version readily install-able on Rocky8
- it requires a later reelase of version 2.X of the Doctrine ORM before the tests will even run.
- This involves supplying seperate composer.json/lock files to run different versions of Doctrine, as there is no version that supports both PHP <7.4 and >7.4. - Drop the experimental from the PHP 7.4 test as it is now expected to pass.
- all tests are currently expected to pass.
- As of PHP 7.2.0 count() yields a warning on invalid countable types passed to the value parameter.
- PHP 7.3 and newer versions use a newer underlying library to handle regexes which more strict in the regex pattern validations. - So now these hyphens have to be escaped.
gregcorbett
force-pushed
the
unit_test_php_modern
branch
from
5db1463 to
ac8c016
Compare
gregcorbett
force-pushed
the
unit_test_php_modern
branch
from
ac8c016 to
1ea3fa7
Compare
gregcorbett
changed the title
gregcorbett
force-pushed
the
unit_test_php_modern
branch
2 times, most recently
from
2af5d69 to
1ea3fa7
Compare
tofu-rocketry
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the test MariaDB tests to:
Fixing the PHP 7.4 test for MariaDB highlighted a few things that wouldn't work under PHP 7.4 and this PR also addresses those.