Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 7.4 MariaDB test, Drop experimental MariaDB tests #491

Merged
merged 7 commits into from
Oct 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 14 additions & 22 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,38 +7,28 @@ jobs:
phpunit-mariadb:
name: "PHPUnit with MariaDB: ${{ matrix.mariadb-version }}, PHP: ${{ matrix.php-version }}, extension: ${{ matrix.extension }}"
runs-on: ubuntu-latest
# If true, allow the job to fail:
continue-on-error: ${{ matrix.experimental }}
strategy:
# If true, stop jobs if a required job fails:
fail-fast: false
matrix:
# Define jobs for all combinations of php, mariadb and extension, up to "include"
# Tests will be performed for each combination
# These can fail if "experimental" is true. Currently all must pass
php-version: ["5.4", "5.5", "5.6", "7.0", "7.1"]
php-version: ["5.4", "5.5", "5.6", "7.0", "7.1", "7.4"]
mariadb-version: ["10.3"]
extension: ["pdo_mysql"]
experimental: [false]
include:
# Define jobs for individual combinations to be tested
# These can fail if "experimental" is true. Currently all can fail
- php-version: "7.2"
mariadb-version: "10.3"
extension: "pdo_mysql"
experimental: true
- php-version: "7.3"
mariadb-version: "10.3"
extension: "pdo_mysql"
experimental: true
- php-version: "5.4"
composer-json: "composer.json"
tofu-rocketry marked this conversation as resolved.
Show resolved Hide resolved
- php-version: "5.5"
composer-json: "composer.json"
- php-version: "5.6"
composer-json: "composer.json"
- php-version: "7.0"
composer-json: "composer.json"
- php-version: "7.1"
composer-json: "composer.json"
- php-version: "7.4"
mariadb-version: "10.3"
extension: "pdo_mysql"
experimental: true
- php-version: "8.0"
mariadb-version: "10.3"
extension: "pdo_mysql"
experimental: true
composer-json: "composer-7.4.json"

services:
mariadb:
Expand Down Expand Up @@ -79,6 +69,8 @@ jobs:
${{ runner.os }}-php-

- name: Install dependencies
env:
COMPOSER: ${{ matrix.composer-json }}
run: composer install --no-progress

- name: Set up unit testing
Expand Down
15 changes: 15 additions & 0 deletions composer-7.4.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"name": "stfc-egi/gocdb",
"description": "A web portal and REST style API for e-Infrastructure topology managment",
"require": {
"doctrine/orm": "2.6.*"
},
"require-dev": {
"phpunit/phpunit": "4.8.*",
"phpunit/dbunit": ">=1.2",
"phpmd/phpmd": "^2.13",
"squizlabs/php_codesniffer": "^3.7",
"taq/pdooci": "^1.0"

}
}
Loading